Replace service by singletons, use Kotlin coroutines #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnyminerZ
reviewed
Aug 29, 2023
ArnyminerZ
requested changes
Aug 29, 2023
sample-app/src/main/java/at/bitfire/cert4android/demo/MainActivity.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Arnau Mora <[email protected]>
|
Works great for me |
Signed-off-by: Arnau Mora <[email protected]>
rfc2822
force-pushed
the
remove-service
branch
from
f7e53b4
to
3e5ec4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #24, closes #20
@ArnyminerZ Took some time to understand your idea to use Continuation, but I like it. I've also rewritten the rest so that it doesn't use a Service anymore and has a better structure.
Can you please try it out and see whether it works for you? Or if you have other comments.